Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stop job message clearer #12252

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

rkarthick
Copy link
Contributor

Make stop job message clearer to ensure job is not stopped by mistake instead of allocation

Decided to create a PR instead of requesting for change. Open to suggestions :)

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @rkarthick!

This a great clarity improvement. I pushed a couple of PRs to apply the same change to other two-step buttons that we have and also add a CHANGELOG entry.

@lgfa29 lgfa29 merged commit 17347c5 into hashicorp:main Mar 24, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants